Merged
Conversation
- Bumped version in GitVersion.yml to 6.3.3 and enabled commit message incrementing for continuous delivery. - Added `CustomsPaymentType` property to `ShipmentDetails` class with appropriate documentation. - Modified payment handling in `FedExShipmentProvider` to use `CustomsPaymentType` in the switch statement, simplifying the logic for the "RECIPIENT" case.
Update versioning and enhance payment handling logic
Updated the DutiesPayment property to include a new Payor object. This object now contains a ResponsibleParty with an AccountNumber set from shipmentDetails, improving the payment handling logic.
Introduce handling for "THIRD_PARTY" payment type in the FedEx shipment processing. Set up `ShippingChargesPayment` with appropriate `Payment` object and account number. Add default case for other payment types to set `DutiesPayment` as `RECIPIENT`.
Enhance DutiesPayment structure in FedExShipmentProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.